feat: Add parseHtml #156
Open
feat: Add parseHtml #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 6, 2025
samunohito
reviewed
Jan 6, 2025
Comment on lines
+175
to
+201
| html: r => { | ||
| return P.alt([ | ||
| // Regexp | ||
| r.unicodeEmoji, | ||
| // "<center>" block | ||
| r.centerTag, | ||
| // "<small>" | ||
| r.smallTag, | ||
| // "<plain>" | ||
| r.plainTag, | ||
| // "<b>" | ||
| r.boldTag, | ||
| // "<i>" | ||
| r.italicTag, | ||
| // "<s>" | ||
| r.strikeTag, | ||
| // "@" | ||
| r.mention, | ||
| // "#" | ||
| r.hashtag, | ||
| // ":" | ||
| r.emojiCode, | ||
| // http | ||
| r.url, | ||
| r.text, | ||
| ]); | ||
| }, |
There was a problem hiding this comment.
以下の要素で囲われた文字列の中に、**や__のようなMFMとして意味のある記号が存在した時の挙動が気になっております。
- centerTag
- smallTag
- boldTag
- italicTag
- strikeTag
html用のパーサに含まれている上記はinlineを使用して再帰的に解析を行うものであり、<center>タグの中に**などがあった場合、MFMとして認識されてしまわないかという点を懸念しております。
There was a problem hiding this comment.
あー、そうすると、インライン用の解析器をわけて別途制限しないとダメかな
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
parseHtml APIを追加し、MFM未対応実装のNoteに含まれるHTMLを期待通りにパースできるようにします。
Why
MFM未対応実装のNoteに含まれるHTMLは、従来のparse APIでは投稿者が意図していない解釈となります。
MFM構文のうち、対応HTMLタグ、メンション、ハッシュタグ、URL、絵文字コード、Unicode絵文字のみパースするAPIを追加することにより、過剰な解釈を行わず、適切に解釈できる機能を提供します。
Additional info (optional)
Fix #155
See misskey-dev/misskey#15217