Maya attempt 2 #10
Merged
Maya attempt 2 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalacho-mit
commented
May 21, 2024
src/lib/default-project/index.js
Outdated
| /* eslint-enable import/no-unresolved */ | ||
|
|
||
| function base64ToArrayBuffer(base64) { |
|
@mayarajan3 can you delete the |
pmalacho-mit
commented
May 21, 2024
src/components/menu-bar/menu-bar.css
Outdated
| @@ -32,7 +32,7 @@ | |||
| font-family: "Helvetica Neue", Helvetica, Arial, sans-serif; | |||
| font-size: $menu-bar-standard-font-size; | |||
| font-weight: bold; | |||
| background-color: $looks-secondary; | |||
There was a problem hiding this comment.
There's actually a few places where the interface is now purple where it used to be blue, like:
I think it might make more sense to try changing the looks-secondary css variable to the value of motion-primary variable and assess if that returns us to our preferred blue state ™️
pmalacho-mit
merged commit 7701767
into
parkers-change-maya-attempt-1
5 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
What Github issue does this resolve (please include link)?
Proposed Changes
Describe what this Pull Request does
Reason for Changes
Explain why these changes should be made
Test Coverage
Please show how you have added tests to cover your changes
Browser Coverage
Check the OS/browser combinations tested (At least 2)
Mac
Windows
Chromebook
iPad
Android Tablet