Fix PPP compilation error in ESP32 Core v3.x.x

mobizt · Dec 25, 2024 · a09bf8b · a09bf8b
1 parent 0d02fb8
commit a09bf8b
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 17 deletions.
diff --git a/README.md b/README.md
@@ -2,11 +2,11 @@
 
 ![GitHub Actions Workflow Status](https://img.shields.io/github/actions/workflow/status/mobizt/FirebaseClient/.github%2Fworkflows%2Fcompile_library.yml?logo=github&label=compile) [![Github Stars](https://img.shields.io/github/stars/mobizt/FirebaseClient?logo=github)](https://github.com/mobizt/FirebaseClient/stargazers) ![Github Issues](https://img.shields.io/github/issues/mobizt/FirebaseClient?logo=github)
 
-![GitHub Release](https://img.shields.io/github/v/release/mobizt/FirebaseClient) ![Arduino](https://img.shields.io/badge/Arduino-v1.4.11-57C207?logo=arduino) ![PlatformIO](https://badges.registry.platformio.org/packages/mobizt/library/FirebaseClient.svg) ![GitHub Release Date](https://img.shields.io/github/release-date/mobizt/FirebaseClient)
+![GitHub Release](https://img.shields.io/github/v/release/mobizt/FirebaseClient) ![Arduino](https://img.shields.io/badge/Arduino-v1.4.12-57C207?logo=arduino) ![PlatformIO](https://badges.registry.platformio.org/packages/mobizt/library/FirebaseClient.svg) ![GitHub Release Date](https://img.shields.io/github/release-date/mobizt/FirebaseClient)
 
 [![GitHub Sponsors](https://img.shields.io/github/sponsors/mobizt?logo=github)](https://github.com/sponsors/mobizt)
 
-Revision `2024-12-21T04:55:10Z`
+Revision `2024-12-25T03:00:36Z`
 
 ## Table of Contents
 

diff --git a/...es/App/NetworkInterfaces/Async/Callback/DefaultNetworks/DefaultPPPNetwork/ESP32/ESP32.ino b/...es/App/NetworkInterfaces/Async/Callback/DefaultNetworks/DefaultPPPNetwork/ESP32/ESP32.ino
@@ -30,6 +30,8 @@
 
 #include <Arduino.h>
 
+#include <PPP.h>
+
 #include <FirebaseClient.h>
 
 #include <NetworkClientSecure.h>

diff --git a/.../App/NetworkInterfaces/Async/NoCallback/DefaultNetworks/DefaultPPPNetwork/ESP32/ESP32.ino b/.../App/NetworkInterfaces/Async/NoCallback/DefaultNetworks/DefaultPPPNetwork/ESP32/ESP32.ino
@@ -30,6 +30,8 @@
 
 #include <Arduino.h>
 
+#include <PPP.h>
+
 #include <FirebaseClient.h>
 
 #include <NetworkClientSecure.h>

diff --git a/examples/App/NetworkInterfaces/Sync/DefaultNetworks/DefaultPPPNetwork/ESP32/ESP32.ino b/examples/App/NetworkInterfaces/Sync/DefaultNetworks/DefaultPPPNetwork/ESP32/ESP32.ino
@@ -30,6 +30,8 @@
 
 #include <Arduino.h>
 
+#include <PPP.h>
+
 #include <FirebaseClient.h>
 
 #include <NetworkClientSecure.h>

diff --git a/library.json b/library.json
@@ -1,6 +1,6 @@
 {
   "name": "FirebaseClient",
-  "version": "1.4.11",
+  "version": "1.4.12",
   "keywords": "communication, REST, esp32, esp8266, arduino",
   "description": "Async Firebase Client library for Arduino.",
   "repository": {

diff --git a/library.properties b/library.properties
@@ -1,6 +1,6 @@
 name=FirebaseClient
 
-version=1.4.11
+version=1.4.12
 
 author=Mobizt
 

diff --git a/src/core/Core.h b/src/core/Core.h
@@ -7,7 +7,7 @@
 #undef FIREBASE_CLIENT_VERSION
 #endif
 
-#define FIREBASE_CLIENT_VERSION "1.4.11"
+#define FIREBASE_CLIENT_VERSION "1.4.12"
 
 static void sys_idle()
 {

diff --git a/src/core/Network.h b/src/core/Network.h
@@ -1,5 +1,5 @@
 /**
- * Created December 21, 2024
+ * Created December 25, 2024
  *
  * For MCU build target (CORE_ARDUINO_XXXX), see Options.h.
  *
@@ -269,18 +269,7 @@ typedef void (*NetworkStatusCallback)(bool &);
 
 #if __has_include(<PPP.h>)
 #include <PPP.h>
-#endif
-
 #define FIREBASE_NATIVE_PPP_IS_AVAILABLE
-//  ESP32 Core Enum
-//  PPP_MODEM_GENERIC
-//  PPP_MODEM_SIM7600
-//  PPP_MODEM_SIM7070
-//  PPP_MODEM_SIM7000
-//  PPP_MODEM_BG96
-//  PPP_MODEM_SIM800
-#if defined(CONFIG_ESP_MODEM_ADD_CUSTOM_MODULE)
-//  PPP_MODEM_CUSTOM
 #endif
 
 #endif