63-somnfeature-request---cdxml-file-as-user-input #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #62
Resolves #63
Resolves #64
Staging environment is updated with this PR
Testing Procedure #62
Go to - https://mmli.fastapi.staging.mmli1.ncsa.illinois.edu/docs#/Somn/check_reaction_sites_somn_all_reaction_sites_get
Valid chemical
BrC1=C(C=CC=C1)CO[C@@H]2CCCCO2
, roleel
expected output:
..."has_chiral": true...
,BrC1=C(C=CC=C1)CO[CH]2CCCCO2
, roleel
expected output:
..."has_chiral": false...
,Invalid chemical
BrC1=C(C=CC=C1)CO[CH]2CCCCO
, roleel
expected output:
... "detail": "Invalid SMILES string: BrC1=C(C=CC=C1)CO[C@@H]2CCCCO" ...
Chemical which failed 3d testing
... "detail": "Unable to generate 3D coordinates for XXX" ...
Testing Procedure #63
It is a very rare case and we haven't produced any example for it. However, the feature has been tested with force casting error type to 3d-gen
Testing procedure #64
Go to - https://mmli.fastapi.staging.mmli1.ncsa.illinois.edu/docs#/Somn/check_reaction_sites_somn_all_reaction_sites_get
Number of heavy atoms = number of non-hydrogen atoms
Valid chemical
BrC1=C(C=CC=C1)
, roleel
expected output:
..."num_heavy_atoms": 7...
,BrC1=C(C=CC=C1)CO[C@@H]2CCCCO2
, roleel
expected output:
..."num_heavy_atoms": 15...
,Invalid chemical
BrC1=C(C=CC=C1)CO[CH]2CCCCO
, roleel
expected output:
... "detail": "Invalid SMILES string: BrC1=C(C=CC=C1)CO[C@@H]2CCCCO" ...
Chemical which failed 3d testing
... "detail": "Unable to generate 3D coordinates for XXX" ...