Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

63-somnfeature-request---cdxml-file-as-user-input #67

Merged
merged 8 commits into from
Dec 11, 2024

Conversation

ckouder
Copy link
Contributor

@ckouder ckouder commented Oct 31, 2024

Resolves #62
Resolves #63
Resolves #64

Staging environment is updated with this PR

Testing Procedure #62

Go to - https://mmli.fastapi.staging.mmli1.ncsa.illinois.edu/docs#/Somn/check_reaction_sites_somn_all_reaction_sites_get

  • Valid chemical

    • with chiral BrC1=C(C=CC=C1)CO[C@@H]2CCCCO2, role el
      expected output: ..."has_chiral": true...,
    • without chiral BrC1=C(C=CC=C1)CO[CH]2CCCCO2, role el
      expected output: ..."has_chiral": false...,
  • Invalid chemical

    • BrC1=C(C=CC=C1)CO[CH]2CCCCO, role el
      expected output: ... "detail": "Invalid SMILES string: BrC1=C(C=CC=C1)CO[C@@H]2CCCCO" ...
  • Chemical which failed 3d testing

    • TBD
    • expected output: ... "detail": "Unable to generate 3D coordinates for XXX" ...

Testing Procedure #63

It is a very rare case and we haven't produced any example for it. However, the feature has been tested with force casting error type to 3d-gen

Testing procedure #64

Go to - https://mmli.fastapi.staging.mmli1.ncsa.illinois.edu/docs#/Somn/check_reaction_sites_somn_all_reaction_sites_get

Number of heavy atoms = number of non-hydrogen atoms

  • Valid chemical

    • without hydrogenBrC1=C(C=CC=C1), role el
      expected output: ..."num_heavy_atoms": 7...,
    • with hydrogen BrC1=C(C=CC=C1)CO[C@@H]2CCCCO2, role el
      expected output: ..."num_heavy_atoms": 15...,
  • Invalid chemical

    • BrC1=C(C=CC=C1)CO[CH]2CCCCO, role el
      expected output: ... "detail": "Invalid SMILES string: BrC1=C(C=CC=C1)CO[C@@H]2CCCCO" ...
  • Chemical which failed 3d testing

    • TBD
    • expected output: ... "detail": "Unable to generate 3D coordinates for XXX" ...

@ckouder ckouder requested a review from David-Bianchi October 31, 2024 18:45
@ckouder ckouder linked an issue Oct 31, 2024 that may be closed by this pull request
@ckouder ckouder changed the title 63 somnfeature request cdxml file as user input somnfeature request - add has_chiral and num_heavy_atoms Nov 1, 2024
@ckouder ckouder changed the title somnfeature request - add has_chiral and num_heavy_atoms 63-somnfeature-request---cdxml-file-as-user-input Nov 1, 2024
@ckouder
Copy link
Contributor Author

ckouder commented Nov 1, 2024

blocked at #63 - detailed in issue page

@ckouder ckouder closed this Nov 1, 2024
Copy link

@David-Bianchi David-Bianchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bingji!

@ckouder ckouder merged commit 7bc2edf into main Dec 11, 2024
2 checks passed
@ckouder ckouder deleted the 63-somnfeature-request---cdxml-file-as-user-input branch December 11, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants