🐛 Fix RegExp bug when normalizing repeated characters in a string

motss · Jul 13, 2019 · d4eecf1 · d4eecf1
1 parent 65ea1eb
commit d4eecf1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/normalize_diacritics/helpers.ts b/normalize_diacritics/helpers.ts
@@ -244,6 +244,6 @@ export const diacritics: Diacritics[] = [
 // tslint:enable:max-line-length
 
 export function removeDiacritics(s: string) {
-  const normalized = diacritics.find(n => n.diacritics.test(s));
+  const normalized = diacritics.find(n => (new RegExp(n.diacritics)).test(s));
   return null == normalized ? s : normalized.letter;
 }
diff --git a/normalize_diacritics/normalize.test.ts b/normalize_diacritics/normalize.test.ts
@@ -56,11 +56,19 @@ async function willNormalizeNonAccentedCharacter() {
   assertStrictEq(await normalize("\u00d8"), "O");
 }
 
+async function willNormalizeRepeatedCharacters() {
+  assertStrictEq(await normalize("éééé"), "eeee");
+  assertStrictEq(await normalize("åååå"), "aaaa");
+  assertStrictEq(await normalize("éåéåéåéå"), "eaeaeaea");
+  assertStrictEq(await normalize("åéåéåéåé"), "aeaeaeae");
+}
+
 prepareTest([
   willSkipNormalizationForEmptyCharacter,
   willNormalizeSingleCharacter,
   willNormalizeAccentedCharacters,
   willNormalizeAccentedCharactersWithoutUsingNativeFunction,
   willReturnOriginalCharacterWhenNoMatchFound,
-  willNormalizeNonAccentedCharacter
+  willNormalizeNonAccentedCharacter,
+  willNormalizeRepeatedCharacters,
 ], "normalize_diacritics");