Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide dropdown when no valid recent requests exist #141

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Hide dropdown when no valid recent requests exist #141

wants to merge 4 commits into from

Conversation

peimn
Copy link
Contributor

@peimn peimn commented Dec 13, 2024 •
edited
Loading

Fixes an issue where the dropdown would display even when no valid recent requests were available. Ensures the dropdown only appears when there are meaningful items to show.

Screenshot 2024-12-13 at 3 17 01 PM Screenshot 2024-12-13 at 3 16 32 PM

gschier
gschier requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@gschier gschier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right that this should be improved. However, I would prefer to show an empty state so the dropdown is still usable with no active request.

Then EnvironmentActionsDropdown does this, for reference.

@peimn peimn requested a review from gschier December 17, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gschier gschier Awaiting requested review from gschier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peimn @gschier