Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug caused by colcon when building with symlinks #124

Open
wants to merge 1 commit into
base: ros2
Choose a base branch
from

Conversation

JafarAbdi
Copy link
Member

@JafarAbdi JafarAbdi commented Apr 28, 2021

There's a bug in colcon causing the build to fail if the workspace contains a python package with a symlink -- see 1 & 2

To fix this I copied the workspace rather than symlinking it

@JafarAbdi JafarAbdi requested a review from henningkayser April 28, 2021 11:14
@tylerjw
Copy link
Member

tylerjw commented Apr 28, 2021

What repos are affected by this? Should we not just migrate them off this onto github actions?

@JafarAbdi
Copy link
Member Author

What repos are affected by this? Should we not just migrate them off this onto github actions?

It's a private repo we're working on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants