Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed migration relavant issues and added some limitations to CI #42

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

CihatAltiparmak
Copy link
Member

@CihatAltiparmak CihatAltiparmak commented Oct 7, 2024

With this PR, The issues related to migration to moveit organization is solved.

Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, what is necessary for the last CI Job to pass?

@CihatAltiparmak CihatAltiparmak force-pushed the fix/migration_to_moveit_organization_issues branch from 2d8c16b to c308fad Compare October 16, 2024 13:47
@CihatAltiparmak
Copy link
Member Author

CihatAltiparmak commented Oct 16, 2024

Benchmarks inside CI uses the docker image created by github actions. This dockerfile always clones from main branch. When we merge this PR, i hope this CI will work.

Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, as you stated in your comment I forgot this 🙈 but I think it makes sense. Go ahead!

@CihatAltiparmak CihatAltiparmak merged commit eda9ff1 into main Nov 5, 2024
5 of 6 checks passed
@CihatAltiparmak CihatAltiparmak deleted the fix/migration_to_moveit_organization_issues branch November 5, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants