Skip to content
This repository has been archived by the owner on Nov 13, 2017. It is now read-only.

Allowed planning scene monitor to ignore joint states that are not used #308

Closed
wants to merge 1 commit into from
Closed

Conversation

davetcoleman
Copy link
Member

Baxter publishes two joint states that are fixed in its URDF. Because these variables do not exists, it throws an exception.

I also noted some potential optimizations that perhaps could be done - I haven't done them yet though because I'm not sure if I understand it fully.

@isucan
Copy link
Contributor

isucan commented Sep 9, 2013

I see the benefits of having just one lookup by joint name, but I would rather use JointModel* instead of an index for passing to the functions. I think that might not need additional functions in RobotModel.

@davetcoleman
Copy link
Member Author

So you agree the current method of doing a map lookup on joint_state->name[i] is wasteful, but you are saying the better fix would be to pass the JointModel pointer instead?

@isucan isucan closed this in 47ec438 Sep 10, 2013
@isucan
Copy link
Contributor

isucan commented Sep 10, 2013

Yes, I agree. I just pushed equivalent changes. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants