fixes from review

Bugzilla/Install.pm

@@ -257,6 +257,10 @@ use constant SYSTEM_GROUPS => (
     name        => 'bz_can_disable_mfa',
     description => 'Can disable MFA when editing users',
   },
+  {
+    name        => 'bz_can_async_bulk_edit',
+    description => 'Can asynchronously bulk edit bugs',
+  },
 );
 
 use constant DEFAULT_CLASSIFICATION =>

Bugzilla/Task/BulkEdit.pm

@@ -60,7 +60,7 @@ sub _build_ids_with_ts {
 sub run {
   my ($self) = @_;
 
-  return {bulk_edit => 1, all_sent_changes => [map { $self->edit_bug(@$_) } @{$self->ids_with_ts}]};
+  return {async_bulk_edit => 1, all_sent_changes => [map { $self->edit_bug(@$_) } @{$self->ids_with_ts}]};
 }
 
 sub edit_bug {

process_bug.cgi

@@ -76,10 +76,10 @@ if (Bugzilla->params->{disable_bug_updates}) {
 my @bug_objects;
 my @bug_ids;
 
-# $bulk_edit is whether or not we use the bulk editing code,
+# $async_bulk_edit is whether or not we use the bulk editing code,
 # $background is if the background=1 parameter was passed.
-my $bulk_edit = $cgi->param('bulk_edit') // 0;
-$cgi->delete('bulk_edit') if $bulk_edit;
+my $async_bulk_edit = $cgi->param('async_bulk_edit') // 0;
+$cgi->delete('async_bulk_edit') if $async_bulk_edit;
 
 if (defined $cgi->param('id')) {
   my $bug = Bugzilla::Bug->check(scalar $cgi->param('id'));
@@ -91,10 +91,10 @@ else {
 
   # Make sure there are bugs to process.
   ThrowUserError("no_bugs_chosen", {action => 'modify'}) unless @bug_ids;
-  $bulk_edit = 1 if @bug_ids > 10;
-  $bulk_edit = 0 unless $user->in_group('bulk_edit');
+  $async_bulk_edit = 1 if @bug_ids > 10;
+  $async_bulk_edit = 0 unless $user->in_group('bz_can_async_bulk_edit');
 
-  if ($bulk_edit) {
+  if ($async_bulk_edit) {
     # Not sure if we need $first_bug at all during a bulk update,
     # but it won't hurt.
     @bug_objects = (Bugzilla::Bug->check($bug_ids[0]));
@@ -241,7 +241,7 @@ else {
 # For each bug, we have to check if the user can edit the bug the product
 # is currently in, before we allow them to change anything.
 # For bulk edits, this will be done in the background task.
-if (!$bulk_edit) {
+if (!$async_bulk_edit) {
   foreach my $bug (@bug_objects) {
     if (!Bugzilla->user->can_edit_product($bug->product_obj->id)) {
       ThrowUserError("product_edit_denied", {product => $bug->product});
@@ -273,7 +273,7 @@ my %field_translation = (
 );
 
 my %set_all_fields;
-if (not $bulk_edit) {
+if (not $async_bulk_edit) {
   $set_all_fields{other_bugs} = \@bug_objects;
 }
 else {
@@ -396,7 +396,7 @@ foreach my $field (keys %$user_match_fields) {
 # We are going to alter the list of removed groups, so we keep a copy here.
 my @unchecked_groups = @$removed_groups;
 
-if ($bulk_edit) {
+if ($async_bulk_edit) {
   my $task = Bugzilla::Task::BulkEdit->new(
     ids     => \@bug_ids,
     set_all => \%set_all_fields,

template/en/default/bug/process/bugmail.html.tmpl

@@ -35,7 +35,7 @@
 %]
 [% recipient_count = sent_bugmail.sent.size %]
 
-[% IF bulk_edit %]
+[% IF async_bulk_edit %]
   [% show_recipients = 1 %]
 [% ELSE %]
 <script [% script_nonce FILTER none %]>
@@ -73,7 +73,7 @@
     [% ELSE %]
       no one
     [% END %]
-    [% IF NOT bulk_edit %]
+    [% IF NOT async_bulk_edit %]
       (<a href="#" class="toggleBugmailRecipients" data-mailing-bugid="[% mailing_bugid FILTER html %]"
           data-mailing-show="false">hide</a>)
     [% END %]

template/en/default/bug/process/results.html.tmpl

@@ -34,7 +34,7 @@
 
 [% DEFAULT type="bug" %]
 
-[% IF bulk_edit %]
+[% IF async_bulk_edit %]
   [% Link = BLOCK %][% "$terms.Bug $id" FILTER bug_link(id, full_url => 1) FILTER none %][% END %]
   [% link = BLOCK %][% "$terms.bug $id" FILTER bug_link(id, full_url => 1) FILTER none %][% END %]
 [% ELSE %]

template/en/default/list/edit-multiple.html.tmpl

@@ -370,9 +370,9 @@
 [%+ Hook.process('after_groups') %]
 
 <input type="submit" id="commit" value="Commit">
-<input type="checkbox" id="bulk_edit" name="bulk_edit" value="1">
-[% IF user.in_group('bulk_edit') %]
-  <label for="bulk_edit">Bulk Edit</label>
+[% IF user.in_group('bz_can_async_bulk_edit') %]
+  <label for="async_bulk_edit">Bulk Edit in Background</label>
+  <input type="checkbox" id="async_bulk_edit" name="async_bulk_edit" value="1">
 [% END %]
 
 [%############################################################################%]

template/en/default/task/created.html.tmpl

@@ -8,7 +8,7 @@
 %]
 
 <div id="page-index">
-<p>Scheduled [% task.proper_name FILTER html %] task. You'll recieve an email when it is done.</p>.
+<p>Scheduled [% task.proper_name FILTER html %] task. You'll recieve an email when it is done.</p>
 </div>
 
 [% PROCESS global/footer.html.tmpl %]