Bug 1879792 - Add a cookie banner to BMO #2306
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgsheeh
requested changes
Dec 4, 2024
…s. This doesn't require authenticated sessions. - Added a cookie settings link to the user drop down below preferences and also a cookie settings link on the home page.
cgsheeh
approved these changes
Dec 10, 2024
| if (key.match(/^bug-modal-saved-comment-/)) { | ||
| let value = JSON.parse(localStorage.getItem(key)); | ||
| let value = Bugzilla.Storage.get(key); |
There was a problem hiding this comment.
Out-of-scope nit: I don't really love the implicit JSON handling, it would be better to have a get_json method that handles JSON values instead.
There was a problem hiding this comment.
Not sure why this is an issue as the Bugzilla.Storage class is handling the JSON parsing and stringification behind the scenes now. So the caller will use Bugzilla.Storage.get and the value returned will be a valid JSON object or a single value. So the caller will just need to check of value is typeof object if it is not sure. Bugzilla.Storage.set looks to see if the value passed is and object and if so, it will stringify it as JSON before storing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From bug:
We should include a Cookie Banner on BMO to reduce our exposure to legal risks from changes in EU and US privacy law of the last several years.
BMO has a number of non-essential cookies that improve the UX of the site. Even though these non-essential cookies are not used for tracking purposes, Legal have advised that a cookie banner is still warranted.
Let me know if you have any questions