Bug 1936911 - Add back CIRCLECI_SHA1 AND CIRCLE_BUILD_URL back to the build and deploy steps for CircleCI #2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… build and deploy steps for CircleCI
|
Oops not quite right yet. |
cgsheeh
approved these changes
Dec 13, 2024
docker-compose.test.yml
Outdated
Comment on lines
11
to
12
| args: | ||
| - CI=1 |
There was a problem hiding this comment.
I'm surprised we need to set this and CircleCI doesn't set this when appropriate on its own?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before these changes, the
/app/version.jsonfile had empty values for CIRCLE_SHA1 and CIRCLE_BUILD_URI. This fixes the issue.