Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FXIOS-10205 [Swiftlint] Resolve 3 implicitly_unwrapped_optional violations in SearchEnginesManager #23809

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tonell-m
Copy link
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

Continuing resolving implicitly_unwrapped_optional violations in order to enable the rule for further developments.

Using a lazy property for disabledEngines allows to make all properties non optional instead of implicitly unwrapped, let me know if that's okay for you!

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@tonell-m tonell-m requested a review from a team as a code owner December 17, 2024 14:36
@tonell-m tonell-m requested a review from issammani December 17, 2024 14:36
@lmarceau lmarceau changed the title Refactor FXIOS-10205 - Resolve 3 implicitly_unwrapped_optional violations in SearchEnginesManager Refactor FXIOS-10205 [Swiftlint] Resolve 3 implicitly_unwrapped_optional violations in SearchEnginesManager Dec 17, 2024
Copy link
Collaborator

@PARAIPAN9 PARAIPAN9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@PARAIPAN9
Copy link
Collaborator

Hey @tonell-m!! We have this error ❌ /Users/vagrant/git/firefox-ios/firefox-ios-tests/Tests/ClientTests/Frontend/Homepage Rebuild/Mock/MockSearchEngineManager.swift:9:7: type 'MockSearchEnginesManager' does not conform to protocol 'SearchEnginesManagerProvider'. We've changed the protocol requiremens so we'd have to also adjust our tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants