Refactor FXIOS-10205 [Swiftlint] Resolve 2 implicitly_unwrapped_optional violations in Profile #23897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts when rebasing. Could you fix it @tonell-m? 🙏 |
tonell-m
force-pushed
the
fxios-10205/profile
branch
from
6c18bee to
f4b5ff2
Compare
cyndichin
reviewed
Dec 27, 2024
| @@ -1,7 +1,7 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <Scheme | |||
| LastUpgradeVersion = "1610" | |||
| version = "1.7"> | |||
| version = "1.8"> | |||
There was a problem hiding this comment.
@tonell-m should we remove this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Continuing resolving
implicitly_unwrapped_optionalviolations in order to enable the rule for further developments.This will most likely conflict with #23861 so I'll rebase with main depending on which gets merged first.
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)