Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FXIOS-10886 [Bookmarks Evolution] Desktop bookmarks header #23965

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MattLichtenstein
Copy link
Collaborator

📜 Tickets

Jira ticket
Github issue

💡 Description

  • Add "desktop bookmarks" header inline within the folder hierarchy parent folder folder selector
  • Move desktop bookmark folders to be the first folders inside the "Bookmarks" folder hierarchy within the parent folder selector
  • Give the desktop bookmarks an extra indentation from other children in the "Bookmarks" folder hierarchy within the parent folder selector

*Note: These changes were made to both the "Edit bookmark" and "Edit folder" screens

📷 Screenshots

Before After
Simulator Screenshot - iPhone 16 - 2024-12-27 at 16 48 19 Simulator Screenshot - iPhone 16 - 2024-12-27 at 16 46 32
Simulator Screenshot - iPhone 16 - 2024-12-27 at 16 48 22 Simulator Screenshot - iPhone 16 - 2024-12-27 at 16 46 37

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 34.21%
📖 Edited 5 files
📖 Created 0 files

Client.app: Coverage: 32.57

File Coverage
EditBookmarkViewController.swift 2.66% ⚠️
FolderHierarchyFetcher.swift 81.46%
EditFolderViewController.swift 3.17% ⚠️
OneLineTableViewCell.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against c3695a1

Copy link

@DreamLord1980 DreamLord1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants