Add a way to show links to MDN, and show them for a number of specs. #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, I realize I should also make the |
dbaron
added a commit
to dbaron/standards-positions
that referenced
this pull request
Jul 15, 2020
…ozilla#396, part 2) This fixes part of mozilla#375. It does the following: * adds an `mdnUrl` field to `activities.json`, using @adamroach's list in mozilla#375 (comment) which can either be a string or an array of strings (like `mozBugUrl`) * adds a way to show the MDN icon in the "More Info" column (which I commit as an asset rather than picking a glyphicon, and use via CSS mask). * adds code to validate the new field in activities.py (matching `mozBugUrl`) * adds code to add the new field for the `add` verb in `activities.py`
martinthomson
approved these changes
Jul 15, 2020
There was a problem hiding this comment.
Fewer links for WebMIDI would be ideal. I guess that it isn't really worth creating Web_MIDI_API just to resolve the broken link on all of those pages.
(I didn't check all of the links. I only skimmed them, I'm trusting that you found reasonable destinations.)
tantek
approved these changes
Jul 20, 2020
There was a problem hiding this comment.
Agreed with @martinthomson and LGTM. Per suggestion that https://developer.mozilla.org/en-US/docs/Web/API/Web_MIDI_API should exist, can we request that explicitly of MDN? And if that request is a GH issue perhaps that could be linked here too.
…ozilla#396, part 2) This fixes part of mozilla#375. It does the following: * adds an `mdnUrl` field to `activities.json`, using @adamroach's list in mozilla#375 (comment) which can either be a string or an array of strings (like `mozBugUrl`) * adds a way to show the MDN icon in the "More Info" column (which I commit as an asset rather than picking a glyphicon, and use via CSS mask). * adds code to validate the new field in activities.py (matching `mozBugUrl`) * adds code to add the new field for the `add` verb in `activities.py` Co-authored-by: Martin Thomson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a way to show links to MDN, and show them for a number of specs.
This fixes part of #375. It does the following:
adds an
mdnUrlfield toactivities.json, using @adamroach's list inconsider replacing caniuse links with MDN links #375 (comment)
which can either be a string or an array of strings (like
mozBugUrl)adds a way to show the MDN icon in the "More Info" column (which I
commit as an asset rather than picking a glyphicon, and use via CSS
mask).
adds code to validate the new field in activities.py (matching
mozBugUrl)adds code to add the new field for the
addverb inactivities.pyThere's also an initial commit to fix something I broke in #385, so this should be rebased rather than squashed.