fixed generate summary/description bug if route is a closure

mtrajano · Aug 29, 2019 · a8fe6a6 · a8fe6a6
1 parent 1033109
commit a8fe6a6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/src/Generator.php b/src/Generator.php
@@ -110,8 +110,7 @@ protected function getRouteUri(Route $route)
 
     protected function generatePath()
     {
-        $requestMethod = strtoupper($this->method);
-        $actionInstance = $this->action ? $this->getActionClassInstance($this->action) : null;
+        $actionInstance = is_string($this->action) ? $this->getActionClassInstance($this->action) : null;
         $docBlock = $actionInstance ? ($actionInstance->getDocComment() ?: "") : "";
 
         list($isDeprecated, $summary, $description) = $this->parseActionDocBlock($docBlock);

diff --git a/tests/GeneratorTest.php b/tests/GeneratorTest.php
@@ -76,6 +76,7 @@ public function testHasPaths($docs)
             '/users',
             '/users/{id}',
             '/users/details',
+            '/users/ping',
             '/api',
             '/api/store',
         ], array_keys($docs['paths']));
@@ -206,7 +207,7 @@ public function testFiltersRoutes($routeFilter, $expectedRoutes)
     public function filtersRoutesProvider()
     {
         return [
-            'No Filter' => [null, ['/users', '/users/{id}', '/users/details', '/api', '/api/store']],
+            'No Filter' => [null, ['/users', '/users/{id}', '/users/details', '/users/ping', '/api', '/api/store']],
             '/api Filter' => ['/api', ['/api', '/api/store']],
             '/=nonexistant Filter' => ['/nonexistant', []],
         ];

diff --git a/tests/TestCase.php b/tests/TestCase.php
@@ -17,6 +17,9 @@ protected function getEnvironmentSetUp($app)
         $app['router']->get('/users/{id}', 'Mtrajano\\LaravelSwagger\\Tests\\Stubs\\Controllers\\UserController@show');
         $app['router']->post('/users', 'Mtrajano\\LaravelSwagger\\Tests\\Stubs\\Controllers\\UserController@store');
         $app['router']->get('/users/details', 'Mtrajano\\LaravelSwagger\\Tests\\Stubs\\Controllers\\UserController@details');
+        $app['router']->get('/users/ping', function() {
+            return 'pong';
+        });
         $app['router']->get('/api', 'Mtrajano\\LaravelSwagger\\Tests\\Stubs\\Controllers\\ApiController@index');
         $app['router']->put('/api/store', 'Mtrajano\\LaravelSwagger\\Tests\\Stubs\\Controllers\\ApiController@store');
     }