Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code-infra] Polish VS Code DX #4562

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[code-infra] Polish VS Code DX #4562

wants to merge 2 commits into from
+42 −14

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari added scope: code-infra Specific to the core-infra product dx Related to developers' experience enhancement This is not a bug, nor a new feature labels Dec 27, 2024
oliviertassinari
oliviertassinari commented Dec 27, 2024
View reviewed changes
.vscode/settings.json
"editor.codeActionsOnSave": {
"source.fixAll.eslint": "explicit"
},
"editor.formatOnSave": true,
Copy link
Member Author

@oliviertassinari oliviertassinari Dec 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How mui/material-ui#44865 started, I was annoyed by this setting. It felt too opinionated to be shared with everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharatkashyap bharatkashyap bharatkashyap approved these changes

Assignees
No one assigned
Labels
dx Related to developers' experience enhancement This is not a bug, nor a new feature scope: code-infra Specific to the core-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliviertassinari @bharatkashyap