Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App header can show previous account remaining time #5342

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Oct 23, 2023


This change is Reviewable

@linear
Copy link

linear bot commented Oct 23, 2023

DROID-418 App header shows previous account's remaining time first

Steps to reproduce:

WhatsApp Video 2023-10-17 at 10.43.14 AM.mp4

  • open the app and login with first account (should have remaining time)
  • check remaining time on connect screen's header
  • logout and login with different account (should have remaining time different than previous one)
  • check remaining time
  • go to account settings
  • back to main view
  • check remaining time

@Rawa Rawa self-assigned this Oct 23, 2023
@Rawa Rawa added the Android Issues related to Android label Oct 23, 2023
@Rawa Rawa requested review from Pururun and sabercodic October 23, 2023 08:51
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the app-header-shows-previous-accounts-remaining-time-first-droid-418 branch from 91c1558 to 2b2eb09 Compare October 25, 2023 09:53
@Pururun Pururun force-pushed the app-header-shows-previous-accounts-remaining-time-first-droid-418 branch from 2b2eb09 to dda6f7a Compare October 25, 2023 13:17
@Pururun Pururun merged commit 31a7a50 into main Oct 25, 2023
9 checks passed
@Pururun Pururun deleted the app-header-shows-previous-accounts-remaining-time-first-droid-418 branch October 25, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants