Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select location UI fixes #5384

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Select location UI fixes #5384

merged 1 commit into from
Oct 30, 2023

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Oct 30, 2023 •
edited by faern
Loading

  • Adds alpha to chevron
  • Simplifies chevron animation
  • Add missing vertical divider

This change is Reviewable

@linear
Copy link

linear bot commented Oct 30, 2023

DROID-454 Select location UI fixes

  • Fix the missing divider between chevron and item name
  • Fix transparency on chevron

@Rawa Rawa self-assigned this Oct 30, 2023
@Rawa Rawa added the Android Issues related to Android label Oct 30, 2023
@Rawa Rawa requested review from sabercodic, albin-mullvad and Pururun and removed request for albin-mullvad October 30, 2023 10:10
Pururun
Pururun approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the select-location-ui-fixes-droid-454 branch from a9ec09a to 750b09f Compare October 30, 2023 13:00
Pururun
Pururun approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the select-location-ui-fixes-droid-454 branch from 750b09f to d074de3 Compare October 30, 2023 13:58
@Pururun Pururun merged commit 4b4166c into main Oct 30, 2023
9 checks passed
@Pururun Pururun deleted the select-location-ui-fixes-droid-454 branch October 30, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pururun Pururun Pururun approved these changes

@sabercodic sabercodic Awaiting requested review from sabercodic

Assignees

@Rawa Rawa

Labels
Android Issues related to Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rawa @Pururun