-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add end to end connection tests for multihop ios 778 #6914
Add end to end connection tests for multihop ios 778 #6914
Conversation
15205fd
to
9f670e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 8 files at r2, 7 of 7 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
dd4fcd2
to
ed5b710
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 7 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)
ios/MullvadVPNUITests/RelayTests.swift
line 269 at r4 (raw file):
VPNSettingsPage(app) .tapMultihopSwitch() .swipeDownToDismissModal()
Interestingly enough, if I run this code on an iPhone SE, it doesn't dismiss the settings.
I think we should replace this by tapping the back, and done buttons respectively instead.
ed5b710
to
825b278
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on @buggmagnet and @rablador)
ios/MullvadVPNUITests/RelayTests.swift
line 269 at r4 (raw file):
Previously, buggmagnet wrote…
Interestingly enough, if I run this code on an iPhone SE, it doesn't dismiss the settings.
I think we should replace this by tapping the back, and done buttons respectively instead.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 7 files at r3, 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
825b278
to
8b1e180
Compare
🚨 End to end tests failed. Please check the failed workflow run. |
This PR adds an end-to-end test for Multihop and fixes minor issues, such as the shrinking of the collapse button in the connection view. Additionally, after changing the data type for the collapse view, we forgot to update the UI tests to ensure compatibility in finding elements.
This change is