Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass secrets to reused workflow #6984

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

pinkisemils
Copy link
Collaborator

@pinkisemils pinkisemils commented Oct 15, 2024

If secrets are not passed explicitly to the called reused action, the called action will not have access to them. Since the secrets contain the device UUID and the partner API token, the tests which invoke the end-to-end action should allow it access to the secrets.


This change is Reviewable

Copy link
Collaborator

@niklasberglund niklasberglund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 3 files reviewed, all discussions resolved

@pinkisemils pinkisemils force-pushed the pass-secrets-to-called-workflow branch from 0b14bc3 to f83b64b Compare October 15, 2024 10:56
@pinkisemils pinkisemils merged commit 291615e into main Oct 15, 2024
7 of 8 checks passed
@pinkisemils pinkisemils deleted the pass-secrets-to-called-workflow branch October 15, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants