Add the openPortSelectorMenuButton accessibility identifier to ... buttons

[acb-mv]

... in VPN Settings

This creates a new AccessibilityIdentifier named .openPortSelectorMenuButton and sets the "..." button, for calling up the port selector menu in obfuscation method cells, to have it. It also refactors VPNSettingsPage, combining the logic for tapping disclosure cells with that for tapping this button.

---

This change is 

[mojganii]

Reviewable status: 0 of 3 files reviewed, 5 unresolved discussions (waiting on @acb-mv)

---

ios/MullvadVPNUITests/Pages/VPNSettingsPage.swift line 62 at r1 (raw file):

    }

    @discardableResult func tapUDPOverTCPPortSelectorButton() -> Self {

these should be revoked instead of the former ones

---

ios/MullvadVPNUITests/Pages/VPNSettingsPage.swift line 74 at r1 (raw file):

    }

    // this button no longer exists

these codes and usages should be removed from here and SettingsMigrationTests

---

ios/MullvadVPNUITests/Pages/VPNSettingsPage.swift line 82 at r1 (raw file):

    // this button no longer exists
    @discardableResult func tapUDPOverTCPPortAutomaticCell() -> Self {

same above

---

ios/MullvadVPNUITests/Pages/VPNSettingsPage.swift line 88 at r1 (raw file):

    }

    // this button no longer exists

same above

---

ios/MullvadVPNUITests/Pages/VPNSettingsPage.swift line 95 at r1 (raw file):

    }

    // this button no longer exists

same above

[acb-mv]

Reviewable status: 0 of 3 files reviewed, 5 unresolved discussions (waiting on @mojganii)

---

ios/MullvadVPNUITests/Pages/VPNSettingsPage.swift line 62 at r1 (raw file):

Previously, mojganii wrote…

these should be revoked instead of the former ones

I will do so in a subsequent PR.

---

ios/MullvadVPNUITests/Pages/VPNSettingsPage.swift line 74 at r1 (raw file):

Previously, mojganii wrote…

these codes and usages should be removed from here and SettingsMigrationTests

They will be in a subsequent PR; I am keeping the old tests which no longer work to crib from for writing the new tests.

---

ios/MullvadVPNUITests/Pages/VPNSettingsPage.swift line 82 at r1 (raw file):

Previously, mojganii wrote…

same above

Noted

---

ios/MullvadVPNUITests/Pages/VPNSettingsPage.swift line 88 at r1 (raw file):

Previously, mojganii wrote…

same above

Noted

---

ios/MullvadVPNUITests/Pages/VPNSettingsPage.swift line 95 at r1 (raw file):

Previously, mojganii wrote…

same above

Noted

[mojganii]

Reviewable status: 0 of 3 files reviewed, 5 unresolved discussions

[rablador]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @mojganii)

[buggmagnet]

Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @mojganii)

[github-actions]

🚨 End to end tests failed. Please check the failed workflow run.

[github-actions]

🚨 End to end tests failed. Please check the failed workflow run.