Add feature indicator pills to connection details

[mojganii]

This pull request introduces a Feature Indicator View that visually displays the enabled settings for the current connection.

---

This change is 

[linear]

IOS-932 Add feature indicator pills to connection details

[rablador]

Reviewed 4 of 10 files at r1, 7 of 7 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @mojganii)

---

ios/MullvadVPN/View controllers/Tunnel/FeatureIndicators/ChipsView/ChipView.swift line 29 at r2 (raw file):

                    lineWidth: 1
                )
                .background(

I think we can set fill (and radius if needed) directly on the rounded rectangle instead.

---

ios/MullvadVPN/View controllers/Tunnel/FeatureIndicators/FeaturesIndicatoresView.swift line 25 at r2 (raw file):

                }

                ScrollView {

This view should not be scrollable. Instead the connection details view should be scrollable.

---

ios/MullvadVPN/View controllers/Tunnel/FeatureIndicators/ChipFeatures.swift line 14 at r2 (raw file):

protocol ChipFeature {
    var isEnabled: Bool { get }
    func name() -> LocalizedStringKey

Nit: Can be a var instead.

---

ios/MullvadVPN/View controllers/Tunnel/FeatureIndicators/ConnectionView.swift line 20 at r2 (raw file):

            VStack(alignment: .leading, spacing: 16) {
                ConnectionPanel()
                FeaturesIndicatoresView(viewModel: FeaturesIndicatoresMockViewModel())

Nit: Typo - FeatureIndicatorsView

[buggmagnet]

Reviewed 1 of 10 files at r1, 3 of 7 files at r2, 2 of 3 files at r3.
Reviewable status: 10 of 11 files reviewed, 6 unresolved discussions (waiting on @mojganii and @rablador)

---

ios/MullvadVPN/View controllers/Tunnel/FeatureIndicators/FeatureChipViewModel.swift line 11 at r3 (raw file):

import Foundation
import MullvadSettings
import SwiftUI

No need for that import

---

ios/MullvadVPN/View controllers/Tunnel/FeatureIndicators/ChipsView/ChipModel.swift line 13 at r3 (raw file):

struct ChipModel: Identifiable {
    let id = UUID()

I wonder if we could be using the name of the chip as a unique identifier instead ?

[rablador]

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @mojganii)

[rablador]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @buggmagnet)

---

ios/MullvadVPN/View controllers/Tunnel/FeatureIndicators/FeatureChipViewModel.swift line 11 at r3 (raw file):

Previously, buggmagnet wrote…

No need for that import

Done.

---

ios/MullvadVPN/View controllers/Tunnel/FeatureIndicators/ChipsView/ChipModel.swift line 13 at r3 (raw file):

Previously, buggmagnet wrote…

I wonder if we could be using the name of the chip as a unique identifier instead ?

Since name is a localized key it would be a little convoluted to turn it back into a string and then use as ID.

[buggmagnet]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @rablador)

---

ios/MullvadVPN/View controllers/Tunnel/FeatureIndicators/ChipsView/ChipModel.swift line 13 at r3 (raw file):

Previously, rablador (Jon Petersson) wrote…

Since name is a localized key it would be a little convoluted to turn it back into a string and then use as ID.

Actually nevermind, Identifiable uses ObjectIdentifier to keep track of things which would require having a class for this to work.

[rablador]

Reviewed 8 of 8 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @buggmagnet and @mojganii)

[rablador]

Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @buggmagnet and @mojganii)

[rablador]

Reviewed 3 of 3 files at r6, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @buggmagnet and @mojganii)

[rablador]

Reviewed 20 of 20 files at r7, 2 of 2 files at r8, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @buggmagnet and @mojganii)

---

ios/MullvadVPN/Views/MainButtonStyle.swift line 1 at r7 (raw file):

//

Opportunistically fixed some colors while I was at it.

[rablador]

Reviewed 21 of 21 files at r10, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @buggmagnet and @mojganii)

[acb-mv]

Reviewed all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @buggmagnet and @mojganii)