Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies #7398

Merged
merged 11 commits into from
Jan 7, 2025
Merged

Bump dependencies #7398

merged 11 commits into from
Jan 7, 2025

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Dec 22, 2024

Fixes DROID-1708


This change is Reviewable

@Rawa Rawa added the Android Issues related to Android label Dec 22, 2024
@Rawa Rawa self-assigned this Dec 22, 2024
@Rawa Rawa force-pushed the bump-dependencies-4 branch 2 times, most recently from dce6907 to 054f39f Compare December 26, 2024 21:53
Copy link

linear bot commented Jan 2, 2025

Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Rawa)


android/gradle/libs.versions.toml line 69 at r1 (raw file):

# Blocked updating to 1.13.13 due to regression
# https://github.com/mockk/mockk/issues/1308

Comment should be removed as it is no longer relevant.

Also we should check if this fixes DROID-1025


android/gradle/verification-keyring.keys line 5426 at r1 (raw file):

sub    CF771F914C2A4A73
-----BEGIN PGP PUBLIC KEY BLOCK-----
Version: BCPG v@RELEASE_NAME@

Any specific reasons this line has been removed?

@Rawa Rawa force-pushed the bump-dependencies-4 branch from 054f39f to 4a06fe8 Compare January 7, 2025 08:49
Copy link
Contributor Author

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @Pururun)


android/gradle/libs.versions.toml line 69 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Comment should be removed as it is no longer relevant.

Also we should check if this fixes DROID-1025

Nice catch, fixed!


android/gradle/verification-keyring.keys line 5426 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Any specific reasons this line has been removed?

Yes, fixed in gradle 8.12.

gradle/gradle#31035

@Rawa Rawa force-pushed the bump-dependencies-4 branch from 4a06fe8 to b82b93d Compare January 7, 2025 09:53
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


android/gradle/verification-keyring.keys line 5426 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

Yes, fixed in gradle 8.12.

gradle/gradle#31035

Nice ⭐

@Rawa Rawa force-pushed the bump-dependencies-4 branch from b82b93d to c5b0b89 Compare January 7, 2025 10:41
@Rawa Rawa merged commit 0951379 into main Jan 7, 2025
32 checks passed
@Rawa Rawa deleted the bump-dependencies-4 branch January 7, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants