-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies #7398
Bump dependencies #7398
Conversation
dce6907
to
054f39f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Rawa)
android/gradle/libs.versions.toml
line 69 at r1 (raw file):
# Blocked updating to 1.13.13 due to regression # https://github.com/mockk/mockk/issues/1308
Comment should be removed as it is no longer relevant.
Also we should check if this fixes DROID-1025
android/gradle/verification-keyring.keys
line 5426 at r1 (raw file):
sub CF771F914C2A4A73 -----BEGIN PGP PUBLIC KEY BLOCK----- Version: BCPG v@RELEASE_NAME@
Any specific reasons this line has been removed?
054f39f
to
4a06fe8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @Pururun)
android/gradle/libs.versions.toml
line 69 at r1 (raw file):
Previously, Pururun (Jonatan Rhodin) wrote…
Comment should be removed as it is no longer relevant.
Also we should check if this fixes DROID-1025
Nice catch, fixed!
android/gradle/verification-keyring.keys
line 5426 at r1 (raw file):
Previously, Pururun (Jonatan Rhodin) wrote…
Any specific reasons this line has been removed?
Yes, fixed in gradle 8.12.
4a06fe8
to
b82b93d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
android/gradle/verification-keyring.keys
line 5426 at r1 (raw file):
Previously, Rawa (David Göransson) wrote…
Yes, fixed in gradle 8.12.
Nice ⭐
b82b93d
to
c5b0b89
Compare
Fixes DROID-1708
This change is