Fix test_upgrade_app fails on Windows
#7421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkusPettersson98
force-pushed
the
test_upgrade_app-fails-on-windows-des-1565
branch
2 times, most recently
from
e3fa0e7 to
da7c9d5
Compare
Serock3
previously approved these changes
Jan 7, 2025
MarkusPettersson98
force-pushed
the
test_upgrade_app-fails-on-windows-des-1565
branch
from
da7c9d5 to
23375cf
Compare
There was a problem hiding this comment.
They actually helped in finding the issue 😉
Reviewable status: 0 of 4 files reviewed, all discussions resolved
Serock3
approved these changes
Jan 7, 2025
MarkusPettersson98
force-pushed
the
test_upgrade_app-fails-on-windows-des-1565
branch
from
23375cf to
5f0cca3
Compare
MarkusPettersson98
deleted the
test_upgrade_app-fails-on-windows-des-1565
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
test_upgrade_apptest on Windows. Themullvadbinary is seemingly not in PATH after upgrading the app. So, as a workaround we use the absolute path instead. This seems to work just fine!This change is