-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enabled pwa feature #288
base: main
Are you sure you want to change the base?
enabled pwa feature #288
Conversation
🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from team will review it as soon as possible. We appreciate your support in making Dataverse better. |
✅ Deploy Preview for multiverse-dataverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amiya-cyber this works fine! But there are some changes required in the paths where files are located:
- Create a new folder named
collections
in the root folder and add themanifest.json
file there. - rename the new
script.js
file created by you toapp.js
and move it towebsite/scripts
folder. - move
sw.js
file towebsite/scripts
folder too. - As the images are being used in website code and not in the software code, move them to
website/web_images
folder.
Don't forget to adjust the paths used in the files accordingly.
Good luck correcting the issues stated. You can ask if you have any doubts.
@amiya-cyber reminder to make the stated changes, its the last chance to make your contribution count for |
Yeah sure |
Description
enabled pwa feature
Related Issue
Fixes #281
Type of change
Checklist
VIDEO PROOF
IMG_9251.MOV