-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MuseSampler: fixed potential compatibility issues #25887
base: master
Are you sure you want to change the base?
MuseSampler: fixed potential compatibility issues #25887
Conversation
I believe this should work to keep instruments consistent. Have we tested by:
If this is all good, it seems like a reasonable change to me. |
I think step "6" may be the one that doesn't work here, because the Do we need to rewrite the data here stored in the score somehow with the updated values? |
68bcf19
to
cc07633
Compare
If we renamed the instrument category, we could indeed have a problem with the mixer menu. Because both the category and the name were part of the resource ID. Now they are not, and we will always use the museUID as the resource ID instead. We will also convert the old ID format to the new one when reading the score. Thus, all checks like resourceMeta1.id == resourceMeta2.id should work fine even if we change the category or name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks :D
Rely only on the museUID, as it remains consistent across versions