-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow reversal of hook flags within Inspector: Chord #25938
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -85,6 +85,7 @@ static constexpr PropertyMetaData propertyList[] = { | |
{ Pid::DIRECTION, false, "direction", P_TYPE::DIRECTION_V, PropertyGroup::POSITION, DUMMY_QT_TR_NOOP("propertyName", "direction") }, | ||
{ Pid::STEM_DIRECTION, false, "StemDirection", P_TYPE::DIRECTION_V, PropertyGroup::APPEARANCE, DUMMY_QT_TR_NOOP("propertyName", "stem direction") }, | ||
{ Pid::NO_STEM, false, "noStem", P_TYPE::INT, PropertyGroup::APPEARANCE, DUMMY_QT_TR_NOOP("propertyName", "no stem") }, | ||
{ Pid::HOOK_REVERSED, false, "hookReverse", P_TYPE::BOOL, PropertyGroup::POSITION, DUMMY_QT_TR_NOOP("propertyName", "reverse hook") }, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably better "hookReversed" or even "reversedHook" (requires changes elsewhere too) and "reversed hook" |
||
{ Pid::SLUR_DIRECTION, false, "up", P_TYPE::DIRECTION_V, PropertyGroup::POSITION, DUMMY_QT_TR_NOOP("propertyName", "up") }, | ||
{ Pid::LEADING_SPACE, false, "leadingSpace", P_TYPE::SPATIUM, PropertyGroup::POSITION, DUMMY_QT_TR_NOOP("propertyName", "leading space") }, | ||
{ Pid::MIRROR_HEAD, false, "mirror", P_TYPE::DIRECTION_H, PropertyGroup::POSITION, DUMMY_QT_TR_NOOP("propertyName", "mirror") }, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2698,6 +2698,8 @@ bool TRead::readProperties(Chord* ch, XmlReader& e, ReadContext& ctx) | |
TRead::read(ss, e, ctx); | ||
ch->add(ss); | ||
} else if (TRead::readProperty(ch, tag, e, ctx, Pid::STEM_DIRECTION)) { | ||
} else if (tag == "hookReverse") { | ||
ch->setHookReversed(e.readBool()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe this needs to get added to read302.cpp too, in order to be able to read this from 3.7 scores? |
||
} else if (tag == "noStem") { | ||
ch->setNoStem(e.readInt()); | ||
} else if (tag == "showStemSlash") { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -159,6 +159,15 @@ FocusableItem { | |
|
||
spacing: 12 | ||
|
||
PropertyCheckBox { | ||
text: qsTrc("inspector", "Reversed hook") | ||
propertyItem: root.chordModel ? root.chordModel.isReverseHook : null | ||
|
||
navigationName: "Reversed hook" | ||
navigationPanel: root.navigationPanel | ||
navigationRowStart: root.navigationRowStart + 1 | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. doesn't seem to work at all... |
||
Item { | ||
height: childrenRect.height | ||
width: parent.width | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated, fixes a Visual Studio warning