Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiment: [plugin/sentry] Use OTEL plugin for Sentry #2334

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

EmrysMyrddin
Copy link
Collaborator

This PR is an experiment to use the OTEL plugin instead of duplicating the instrumentation code.
Sentry is supposed to already use OTEL internally, and should be possible to use an existing OTEL setup with it instead of their dedicated SDK.

Copy link

changeset-bot bot commented Nov 26, 2024

🦋 Changeset detected

Latest commit: e2a011b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@envelop/sentry Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@EmrysMyrddin EmrysMyrddin marked this pull request as draft November 26, 2024 14:46
Copy link
Contributor

github-actions bot commented Nov 26, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@envelop/sentry 11.0.0-alpha-20241126191312-e2a011ba91579deb5c437cacfbae40a208956381 npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Nov 26, 2024

💻 Website Preview

The latest changes are available as preview in: https://89fbdbec.envelop.pages.dev

@theguild-bot
Copy link
Collaborator

theguild-bot commented Nov 26, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.............................................: 100.00% ✓ 762018      ✗ 0     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: 100.00% ✓ 164092      ✗ 0     
     ✓ { mode:envelop-cache-jit }.......................: 100.00% ✓ 333172      ✗ 0     
     ✓ { mode:envelop-just-cache }......................: 100.00% ✓ 165054      ✗ 0     
     ✓ { mode:graphql-js }..............................: 100.00% ✓ 99700       ✗ 0     
     data_received......................................: 2.9 GB  24 MB/s
     data_sent..........................................: 166 MB  1.4 MB/s
     envelop_init.......................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     envelop_total......................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     event_loop_lag.....................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     graphql_context....................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     graphql_execute....................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     graphql_parse......................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     graphql_validate...................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_blocked...................................: avg=2.96µs  min=1.27µs   med=2.6µs   max=3.92ms   p(90)=3.55µs  p(95)=3.96µs 
     http_req_connecting................................: avg=20ns    min=0s       med=0s      max=849.63µs p(90)=0s      p(95)=0s     
     http_req_duration..................................: avg=2.85ms  min=145.64µs med=2.76ms  max=40.84ms  p(90)=5.27ms  p(95)=6.09ms 
       { expected_response:true }.......................: avg=2.85ms  min=145.64µs med=2.76ms  max=40.84ms  p(90)=5.27ms  p(95)=6.09ms 
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=3.38ms  min=500.49µs med=3.03ms  max=19.25ms  p(90)=5.7ms   p(95)=6.22ms 
     ✓ { mode:envelop-cache-jit }.......................: avg=1.48ms  min=145.64µs med=1.23ms  max=17.23ms  p(90)=2.48ms  p(95)=2.64ms 
     ✓ { mode:envelop-just-cache }......................: avg=3.35ms  min=457.14µs med=2.99ms  max=23.36ms  p(90)=5.64ms  p(95)=6.17ms 
     ✓ { mode:graphql-js }..............................: avg=5.73ms  min=523.48µs med=4.92ms  max=40.84ms  p(90)=9.56ms  p(95)=10.38ms
     http_req_failed....................................: 0.00%   ✓ 0           ✗ 381009
     http_req_receiving.................................: avg=37.1µs  min=13.54µs  med=32.21µs max=10.09ms  p(90)=48.98µs p(95)=52.24µs
     http_req_sending...................................: avg=13.08µs min=3.99µs   med=9.98µs  max=15.58ms  p(90)=19.9µs  p(95)=21.34µs
     http_req_tls_handshaking...........................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...................................: avg=2.8ms   min=119.04µs med=2.71ms  max=40.62ms  p(90)=5.21ms  p(95)=6.03ms 
     http_reqs..........................................: 381009  3174.949096/s
     iteration_duration.................................: avg=3.14ms  min=366.23µs med=3.01ms  max=41.39ms  p(90)=5.57ms  p(95)=6.38ms 
     iterations.........................................: 381009  3174.949096/s
     vus................................................: 10      min=10        max=10  
     vus_max............................................: 20      min=20        max=20  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants