Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce equal bus widths #223

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Conversation

netalondon
Copy link
Collaborator

Chip implementation where both sides of a wire had different widths passed in the online IDE, but it should count as an error.

@netalondon netalondon marked this pull request as draft February 1, 2024 11:26
@netalondon netalondon marked this pull request as ready for review February 1, 2024 11:57
Copy link
Collaborator

@DavidSouther DavidSouther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some tests for this?

@DavidSouther DavidSouther merged commit 12b6931 into nand2tetris:main Feb 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants