fix #526: vm emulator raises "call stack exceeded"… #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing println in last row move check for last screen row from printChar to println, so the check runs on every newline command
2 tasks
DavidSouther
approved these changes
Dec 19, 2024
dorianignee
deleted the
fix/vm-emulator-call-stack-exceeded-on-println-in-last-screen-row
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… when doing println in last row
The check for printing past the end of the VM screen was only done in Output.printChar(). So, when an Output.println() command was executed in the last row of the virtual screen, a "call stack exceeded" error message was shown.
I moved the check to the println function, so the cursor will just wrap around to row 0, as intended, when a println occurs in the last line (either by an Output.println() command or by printing past the end of the last line