Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-9878: Update length of Variable - Code System Identifier Meaning … #2203

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

htranho
Copy link
Contributor

@htranho htranho commented Dec 26, 2024

Overview

What is the feature/fix?

Update length of Variable - CodeSystemIdentifierMeaning field from 60 to 120

What is the Solution?

Update json schema file for Variable.

What areas of the application does this impact?

Ingest of Variable - field CodeSystemIdentifierMeaning.

Checklist

  • I have updated/added unit and int tests that prove my fix is effective or that my feature works
  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors corrected
  • I have removed unnecessary/dead code and imports in files I have changed
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

@htranho htranho marked this pull request as draft December 26, 2024 20:39
@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.23%. Comparing base (fe3fde2) to head (763c752).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2203      +/-   ##
==========================================
- Coverage   58.23%   58.23%   -0.01%     
==========================================
  Files        1056     1056              
  Lines       71012    71012              
  Branches     2025     2023       -2     
==========================================
- Hits        41354    41351       -3     
- Misses      27771    27772       +1     
- Partials     1887     1889       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@htranho htranho marked this pull request as ready for review December 26, 2024 23:43
@htranho htranho merged commit 1dd52f5 into master Jan 2, 2025
6 checks passed
htranho added a commit that referenced this pull request Jan 2, 2025
CMR-9878: Update length of Variable - Code System Identifier Meaning …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants