Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

357 sa create needs bounds checking #372

Merged
merged 8 commits into from
Dec 19, 2024

Conversation

Donnie-Ice
Copy link
Contributor

Makes a temporary SA, checks lengths, then saves SA to array. The sa_create function does not currently have a unit test associated with it.

@Donnie-Ice Donnie-Ice self-assigned this Dec 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 3.17460% with 61 lines in your changes missing coverage. Please review.

Project coverage is 75.97%. Comparing base (4567cee) to head (a1e2688).
Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
src/sa/internal/sa_interface_inmemory.template.c 3.17% 61 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #372      +/-   ##
==========================================
- Coverage   76.53%   75.97%   -0.57%     
==========================================
  Files          81       81              
  Lines       22041    22263     +222     
  Branches     1777     1807      +30     
==========================================
+ Hits        16870    16914      +44     
- Misses       4531     4707     +176     
- Partials      640      642       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Donnie-Ice Donnie-Ice linked an issue Dec 17, 2024 that may be closed by this pull request
@Donnie-Ice Donnie-Ice requested review from jlucas9, rjbrown2 and dccutrig and removed request for jlucas9, rjbrown2 and dccutrig December 18, 2024 16:05
@Donnie-Ice Donnie-Ice merged commit 552acda into dev Dec 19, 2024
12 checks passed
@Donnie-Ice Donnie-Ice deleted the 357-sa_create-needs-bounds-checking branch December 19, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sa_create needs bounds checking
4 participants