-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
357 sa create needs bounds checking #372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Donnie-Ice
commented
Dec 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #372 +/- ##
==========================================
- Coverage 76.53% 75.97% -0.57%
==========================================
Files 81 81
Lines 22041 22263 +222
Branches 1777 1807 +30
==========================================
+ Hits 16870 16914 +44
- Misses 4531 4707 +176
- Partials 640 642 +2 ☔ View full report in Codecov by Sentry. |
Donnie-Ice
requested review from
jlucas9,
rjbrown2 and
dccutrig
and removed request for
jlucas9,
rjbrown2 and
dccutrig
December 18, 2024 16:05
jlucas9
approved these changes
Dec 18, 2024
rjbrown2
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes a temporary SA, checks lengths, then saves SA to array. The
sa_create
function does not currently have a unit test associated with it.