Merge pull request #415 from Philipp91/fix414

Tolerate multiple 3956 Rückmeldungen
nemiah · Nov 2, 2023 · 63256e2 · 63256e2
2 parents 3cf73b3 + a8d9da6
commit 63256e2
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/Fhp/FinTs.php b/lib/Fhp/FinTs.php
@@ -471,10 +471,10 @@ public function checkDecoupledSubmission(BaseAction $action): bool
         if ($hitanProcessS === null) {
             throw new UnexpectedResponseException('Missing HITAN with tanProzess=S in the response');
         }
-        $outstanding = $response->findRueckmeldung(Rueckmeldungscode::STARKE_KUNDENAUTHENTIFIZIERUNG_NOCH_AUSSTEHEND);
+        $outstanding = $response->findRueckmeldungen(Rueckmeldungscode::STARKE_KUNDENAUTHENTIFIZIERUNG_NOCH_AUSSTEHEND);
 
         if ($isSuccess) {
-            if ($outstanding !== null) {
+            if ($outstanding) {
                 throw new UnexpectedResponseException('Got both 3956 and HITAN with tanProzess=2');
             }
             $action->setTanRequest(null);
@@ -485,7 +485,7 @@ public function checkDecoupledSubmission(BaseAction $action): bool
                 $this->execute($action);
             }
         } else {
-            if ($outstanding === null) {
+            if (!$outstanding) {
                 throw new UnexpectedResponseException('Got neither 3956 nor HITAN with tanProzess=2');
             }
             $action->setTanRequest($hitanProcessS);