Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency module for install dependencies #4305

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Add dependency module for install dependencies #4305

wants to merge 13 commits into from

Conversation

chemzqm
Copy link
Member

@chemzqm chemzqm commented Oct 19, 2022

No need for npm or yarn for install dependencies of extensions.

  • Cache the downloaded tar files and resovled dependencies to improve the performance.
  • Get the best registry by use Ping when registry not specified in .npmrc
  • Cancel install process when install window close.
  • Choose cancel action by press <tab> in install window.

The missing part:

  • Install optional dependencies, need check os and cpu
  • Symbol link local file dependencies, like v12_language_service:file:v12_language_service
  • Install dependencies from github like github:discordjs/RPC, samjakob/discordjs-rp
  • Install dependencies from git url like git+https://github.com/glayzzle/php-parser.git#27abcb2337ac6450c068ef064982dfabf77916a5

@chemzqm chemzqm changed the title feat(extension): add dependency module Add dependency module for install dependencies Oct 19, 2022
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 91.66% // Head: 91.68% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (39b10c2) compared to base (e650064).
Patch coverage: 90.27% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4305      +/-   ##
==========================================
+ Coverage   91.66%   91.68%   +0.01%     
==========================================
  Files         262      264       +2     
  Lines       24880    25178     +298     
  Branches     5437     5494      +57     
==========================================
+ Hits        22807    23084     +277     
- Misses        874      894      +20     
- Partials     1199     1200       +1     
Impacted Files Coverage Δ
src/index.ts 100.00% <ø> (ø)
src/list/source/extensions.ts 45.36% <ø> (+4.28%) ⬆️
src/extension/ui.ts 92.08% <42.10%> (-7.92%) ⬇️
src/extension/index.ts 96.35% <88.70%> (-2.45%) ⬇️
src/util/index.ts 97.87% <88.88%> (-2.13%) ⬇️
src/model/download.ts 93.57% <90.00%> (-0.60%) ⬇️
src/extension/installer.ts 97.20% <91.42%> (-2.22%) ⬇️
src/extension/dependency.ts 92.88% <92.88%> (ø)
src/util/ping.ts 96.36% <96.36%> (ø)
src/model/fetch.ts 95.71% <100.00%> (-0.72%) ⬇️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chemzqm chemzqm force-pushed the deps branch 3 times, most recently from d79f22c to 4e95818 Compare October 20, 2022 12:30
@fannheyward fannheyward marked this pull request as draft February 21, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant