Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): LSP 3.18 #5126

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(lsp): LSP 3.18 #5126

wants to merge 1 commit into from

Conversation

fannheyward
Copy link
Member

@fannheyward fannheyward commented Aug 26, 2024

  • inlineCompletion
  • SnippetTextEdit

Closes #5071

@fannheyward fannheyward force-pushed the feat/LSP-3.18 branch 2 times, most recently from cf31f11 to b3bcdcb Compare September 2, 2024 02:34
@fannheyward fannheyward force-pushed the feat/LSP-3.18 branch 4 times, most recently from 44e5afa to 8475f49 Compare December 12, 2024 11:16
@fannheyward fannheyward marked this pull request as ready for review December 13, 2024 02:14
@fannheyward fannheyward force-pushed the feat/LSP-3.18 branch 3 times, most recently from 5c9757b to 626d542 Compare December 13, 2024 11:39
- inlineCompletion

Closes #5071
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 72.00000% with 42 lines in your changes missing coverage. Please review.

Project coverage is 97.21%. Comparing base (dce5ae5) to head (a41662e).

Files with missing lines Patch % Lines
src/language-client/client.ts 67.74% 19 Missing and 11 partials ⚠️
src/provider/inlineCompletionItemManager.ts 33.33% 8 Missing ⚠️
src/core/funcs.ts 0.00% 0 Missing and 2 partials ⚠️
src/language-client/index.ts 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5126      +/-   ##
==========================================
- Coverage   97.37%   97.21%   -0.17%     
==========================================
  Files         291      293       +2     
  Lines       27026    27105      +79     
  Branches     5606     5630      +24     
==========================================
+ Hits        26316    26349      +33     
- Misses        496      525      +29     
- Partials      214      231      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fannheyward fannheyward marked this pull request as draft December 18, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support inlineCompletion
1 participant