Implement access control with VPC endpoint checks and block for public internet / VPC #10143

stradig · 2024-12-13T14:49:04Z

Wired up filtering on VPC endpoints
Wired up block access from public internet / VPC depending on per project flag
Added cache invalidation for VPC endpoints (partially based on PR from Raphael)

github-actions · 2024-12-13T15:06:44Z

7095 tests run: 6797 passed, 1 failed, 297 skipped (full report)

Failures on Postgres 17

test_timeline_archival_chaos: release-arm64

# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_timeline_archival_chaos[release-pg17]"

Flaky tests (3)

Postgres 17

test_subscriber_synchronous_commit: release-x86-64
test_timeline_archival_chaos: release-arm64

Postgres 14

test_replica_query_race: release-x86-64

Test coverage report is not available

_{The comment gets automatically updated with the latest test results
12f1ba5 at 2024-12-23T15:51:13.497Z :recycle:}

…red.

proxy/src/control_plane/client/mock.rs

proxy/src/auth/backend/console_redirect.rs

proxy/src/auth/backend/mod.rs

First stab at adding VPC endpoint checks

e6a49f5

stradig added 10 commits December 13, 2024 16:10

Added some more wiring of the cache

04d4f39

Split get_allowed_ips_and_secret into 3 functions

ece5c01

Added metrics for VPC endpoint IDs

89a6ca6

For now of no VCP endpoints are allowed allow all

91ba010

Formatting fixed.

a4d5879

Wired up invalidation of VPC endpoint IDs and block public / private.

1daed01

Formatting fixes.

8858ba0

Wired up flags to block access over public internet or VPC

b639639

Add check to console redirect proxy to block public access if configu…

9bef9bb

…red.

Formatting fixes

eca13bd

stradig changed the title ~~First stab at adding VPC endpoint checks~~ Implement Access control with VPC endpoint checks and block for public internet / VPC Dec 19, 2024

stradig changed the title ~~Implement Access control with VPC endpoint checks and block for public internet / VPC~~ Implement access control with VPC endpoint checks and block for public internet / VPC Dec 19, 2024

stradig requested a review from awarus December 19, 2024 16:20

awarus reviewed Dec 20, 2024

View reviewed changes

proxy/src/control_plane/client/mock.rs Outdated Show resolved Hide resolved

awarus reviewed Dec 20, 2024

View reviewed changes

proxy/src/auth/backend/console_redirect.rs Show resolved Hide resolved

awarus reviewed Dec 20, 2024

View reviewed changes

proxy/src/auth/backend/mod.rs Outdated Show resolved Hide resolved

stradig added 2 commits December 23, 2024 15:56

Addresses review comments from Ivan

12f1ba5

Address clippy comments.

d44df8a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement access control with VPC endpoint checks and block for public internet / VPC #10143

Implement access control with VPC endpoint checks and block for public internet / VPC #10143

stradig commented Dec 13, 2024 •

edited

Loading

github-actions bot commented Dec 13, 2024 •

edited

Loading

Postgres 17

Postgres 14

Implement access control with VPC endpoint checks and block for public internet / VPC #10143

Are you sure you want to change the base?

Implement access control with VPC endpoint checks and block for public internet / VPC #10143

Conversation

stradig commented Dec 13, 2024 • edited Loading

github-actions bot commented Dec 13, 2024 • edited Loading

7095 tests run: 6797 passed, 1 failed, 297 skipped (full report)

Failures on Postgres 17

Postgres 17

Postgres 14

Test coverage report is not available

stradig commented Dec 13, 2024 •

edited

Loading

github-actions bot commented Dec 13, 2024 •

edited

Loading