Add more substantial tests for compute migrations #9811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing worth calling out: is the format of the migration plpsql tests what we want? Would it make more sense to do something like "if neon_superuser is granted access to func_xyz, write a SQL query for func_xyz?" |
7242 tests run: 6890 passed, 0 failed, 352 skipped (full report)Flaky tests (6)Postgres 17
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
b34260a at 2024-12-23T17:26:30.663Z :recycle: |
clipperhouse
approved these changes
Nov 20, 2024
ololobus
reviewed
Dec 5, 2024
tristan957
force-pushed
the
tristan957/migrations
branch
from
6fa910d to
2d5d92c
Compare
|
I think this is pretty good. Perhaps we could add one more test which tests the following scenario: BEGIN;
-- Run migration
-- Fail, causing transaction ABORT
-- Update migration ID
COMMIT;and maybe BEGIN;
-- Run migration
-- Update migration ID
-- Fail, causing transaction ABORT
COMMIT;The purpose would be to make sure that the two operations (running the migration and updating the persisted migration ID) are transactional. Let me know if that sounds worthwhile, and I will add it. |
tristan957
force-pushed
the
tristan957/migrations
branch
from
2d5d92c to
dfe6cc3
Compare
|
Of course when you're reading directory entries they aren't sorted 😆 |
tristan957
force-pushed
the
tristan957/migrations
branch
from
dfe6cc3 to
183df72
Compare
ololobus
approved these changes
Dec 20, 2024
The previous tests really didn't do much. This set should be quite a bit more encompassing. Signed-off-by: Tristan Partin <[email protected]>
tristan957
force-pushed
the
tristan957/migrations
branch
from
183df72 to
b34260a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous tests really didn't do much. This set should be quite a bit more encompassing.