!!! TASK: Raise doctrine/dbal version constraint

[kitsunet]

Neos adjustments for neos/flow-development-collection#2637
Related neos/eventstore-doctrineadapter#17

This may be breaking if you use the iteratable methods of the media Repositories, as those work slightly different now.
You can directly iterate the result of the query operation instead of going back to the iterate method.

[kitsunet]

This is technically ready but needs neos/flow-development-collection#2637 merged before it can work.

No longer because we have upmerged the double compat from 8.4

[mhsdesign]

Added a commit that should be dropped later which should turn the CI green to see as a real e2e check if we missed something in flow.

[kitsunet]

I call this fine for now, see comments regarding the linting problem.

[kdambekalns]

Looks good by reading, and given the tests pass, this should be fine.

Just make sure to drop the CI hack before merge!

[mhsdesign]

Tried it out locally (by lazily creating a new core branch :D)
And Neos seems to boot up.
Also run the Neos Ui e2e tests and they pass.
Thank you for this <3

    "neos/neos-development-collection": "dev-task/temporary-core-branch-for-5161 as 9.0",
    "neos/flow-development-collection": "dev-dependabot/composer/doctrine/dbal-tw-3.2 as 9.0",

also we require https://github.com/neos/eventstore-doctrineadapter/releases/tag/2.0.0 and thus you have to remove "neos/eventstore-doctrineadapter": "^1" or raise it to 2 in your dev dist

The only thing i dindt test gotta be the new media module.

Also i have no idea how we deal with outdated import statements, ill push a commit to adjust use Doctrine\DBAL\DBALException but the scary thing is CI didnt catch it and i dont know if phpstan can.
edit: phpstan works in code that we check, but we dont check everything yet ^^

[kitsunet]

ähhh  @mhsdesign you forced pushed and it's broken now?

[mhsdesign]

i dropped my CI hack commit as i think this is ready to merge

[kitsunet]

Right, flow too? then lets goooooo

[kitsunet]

Alright, I would carefully say this is fine now, whatever might still need adapting can be done as a follow up.

[mhsdesign]

Lol the total diff has become kinda unreviewable with all the casing changes 😅 DbalException -> DBALException etc ... but thanks for not force pushing and putting it nicely in separate commits ... i think i can +1 the additional changes as well ... though i have a question to findAllIterator see flow

[kitsunet]

Well it's a PITA with that exception, I tried to just unify it to DBALException now, instead of doing it one by one because meh.

[kitsunet]

I think nothing in here is raelly a big change apart from the iterable result thing in the media repos...