feat: Pkl language server #3440
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LSP for the Pkl configuration language
justinmk
approved these changes
Nov 17, 2024
glepnir
reviewed
Nov 18, 2024
lua/lspconfig/configs/pkl_lsp.lua
Outdated
|
|
||
| return { | ||
| default_config = { | ||
| cmd = { 'java', '-jar', 'path/to/pkl-lsp.jar' }, |
There was a problem hiding this comment.
The path depends on the user, the path here is just a placeholder.
Updated to match how similarly-configured LSPs are set up.
There was a problem hiding this comment.
what's the point of this config if it requires the user to manually configure the path?
There was a problem hiding this comment.
I looked at a couple other java-based LSPs for inspiration (nextflow_ls, groovyls if you're curious).
I'm happy to remove cmd from default_config, especially since the doc covers it. Let me know what you think fits best :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a language server config for Pkl.
The stars on the LSP repo itself is below the recommended (it's 28 as of writing), but it's fairly new (first release 2 weeks back, October 10) and the main language is at >10k.
It looks as though it's actively developed by the maintainers of the language, and I'd assume development will continue. I've tested the current release locally, and it works as expected.
Let me know if you think it's too early, happy to close this for now and keep a fork around until they make more progress.