-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker.alpine
alternative image
#1512
base: main
Are you sure you want to change the base?
Conversation
Very cool. Looking into the Docker build and push action, you should be able to add this after the current one in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like it would work. Publishing both would be pretty cool
RUN apk update \ | ||
&& apk add --no-cache fwup openssl bash openssl curl jq xdelta3 \ | ||
zip unzip wget musl-locales musl-locales-lang libstdc++ | ||
# Is this needed? libncurses6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is for something related to iex maybe... but I'm not sure. Seems fine to skip for now
# Is this cleanup still needed? | ||
# && apt-get clean && rm -f /var/lib/apt/lists/*_* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Is this cleanup still needed? | |
# && apt-get clean && rm -f /var/lib/apt/lists/*_* |
Nope, drop it!
# Do we need to clean things? | ||
# && apt-get clean && rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Do we need to clean things? | |
# && apt-get clean && rm -rf /var/lib/apt/lists/* |
Nope, drop it!
@jjcarstens did you want to finish this PR? |
For #1427
This builds and starts locally, though I am not Docker-smart enough to actually load a webpage from it.
I believe we could build this alongside with the ubuntu image for a while, maybe with an
-alpine
tag. But I haven't figured out how to add that to the workflow yet./cc @rraub