Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulk move devices to deployment #1718

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Bulk move devices to deployment #1718

merged 4 commits into from
Jan 6, 2025
+231 −6

Conversation

nshoes
Copy link
Contributor

@nshoes nshoes commented Dec 27, 2024 •
edited
Loading

This is a quality-of-life improvement since we're moving away from devices automatically finding deployments.

CleanShot 2024-12-27 at 11 12 48

Todos

  • Tests

@nshoes nshoes force-pushed the bulk-action-devices-move-deployment branch 2 times, most recently from aaffb32 to d62147d Compare December 27, 2024 19:16
@nshoes nshoes marked this pull request as ready for review December 27, 2024 19:18
joshk
joshk requested changes Dec 31, 2024
View reviewed changes
Copy link
Collaborator

@joshk joshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with Nate on a Zoom, we need to check if the device(s) meet the requirements of the Deployment before we assign it to them

@nshoes nshoes force-pushed the bulk-action-devices-move-deployment branch from d62147d to 81a04e2 Compare January 2, 2025 19:49
@nshoes
Copy link
Contributor Author

nshoes commented Jan 2, 2025 •
edited
Loading

With info flash:

CleanShot 2025-01-02 at 11 54 24

There are two other conditions when flashes are shown, check tests if you're interested.

@nshoes nshoes force-pushed the bulk-action-devices-move-deployment branch from 81a04e2 to c88950f Compare January 2, 2025 20:04
@nshoes nshoes requested a review from joshk January 2, 2025 20:04
joshk
joshk requested changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@joshk joshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really awesome, some minor suggested changes.

lib/nerves_hub/devices.ex Outdated Show resolved Hide resolved
lib/nerves_hub/devices.ex Outdated Show resolved Hide resolved
lib/nerves_hub_web/live/devices/index.ex Outdated Show resolved Hide resolved
@nshoes nshoes force-pushed the bulk-action-devices-move-deployment branch from 7ed8b15 to eb7ff24 Compare January 6, 2025 15:50
@nshoes nshoes requested a review from joshk January 6, 2025 16:20
joshk
joshk approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@joshk joshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great. One small comment regarding some dead code.

lib/nerves_hub/devices.ex Outdated Show resolved Hide resolved
@nshoes nshoes force-pushed the bulk-action-devices-move-deployment branch from eb7ff24 to aa3bffa Compare January 6, 2025 22:12
@joshk joshk merged commit 0aab022 into main Jan 6, 2025
2 checks passed
@joshk joshk deleted the bulk-action-devices-move-deployment branch January 6, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshk joshk joshk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nshoes @joshk