Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Juniper SRX240 series device details updated. #2587

Closed
wants to merge 6 commits into from

Conversation

cieska
Copy link
Contributor

@cieska cieska commented Dec 26, 2024

No description provided.

Airflow and comments changed.
Airflow added and comments updated.
@danner26
Copy link
Member

Hello, thank you for contributing. Please resolve all failed test cases before marking this PR as ready to review. Thank you

@danner26 danner26 added the status: revisions needed This issue requires additional information to be actionable label Dec 26, 2024
@cieska
Copy link
Contributor Author

cieska commented Dec 26, 2024

Hello, thank you for contributing. Please resolve all failed test cases before marking this PR as ready to review. Thank you

Hi.
I don't understand what's wrong. Why it didn't passed the checks. Can you lead me where the issue is, please?

@danner26
Copy link
Member

So it looks like you made this on the master branch, and I can't update the branch for you. I think you might be behind on the latest version. I suggest you reset your fork, update to the latest version, then make a new branch off of master in your fork and make your changes. Then submit that as a PR.

I am sorry I cannot assist further at the moment.

@harryajc
Copy link
Collaborator

HI @cieska
It looks like you are past the character limit on a single line for comments

comments: '[Juniper SRX240 Services Gateway Hardware Guide](https://www.juniper.net/documentation/en_US/release-independent/junos/information-products/pathway-pages/hardware/srx240/index.pdf)'
airflow: right-to-left
comments: '[Juniper SRX240 Services Gateway Hardware Guide - PDF](https://www.juniper.net/documentation/en_US/release-independent/junos/information-products/pathway-pages/hardware/srx240/index.pdf).
Highest supported JUNOS software release 12.3X48-D105 (04 Aug 2020) (only with 2GB RAM). [Upgrade SRX RAM guide](https://michaeldale.com.au/archive/2014/08/23/running-junos-121x47-on-first-gen-srx240h/).'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not believe we should have links to unofficial websites within these files. All links should only be to manufacturer websites.

comments: '[Juniper SRX240 Services Gateway Hardware Guide](https://www.juniper.net/documentation/en_US/release-independent/junos/information-products/pathway-pages/hardware/srx240/index.pdf)'
airflow: right-to-left
comments: '[Juniper SRX240 Services Gateway Hardware Guide - PDF](https://www.juniper.net/documentation/en_US/release-independent/junos/information-products/pathway-pages/hardware/srx240/index.pdf).
Highest supported JUNOS software release 12.3X48-D105 (04 Aug 2020) (only with 2GB RAM). [Upgrade SRX RAM guide](https://michaeldale.com.au/archive/2014/08/23/running-junos-121x47-on-first-gen-srx240h/).'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not believe we should have links to unofficial websites within these files. All links should only be to manufacturer websites.

@danner26
Copy link
Member

Hello @cieska as states on the individual files I do not think we should have links to external websites that are non-official documentation. Please remove these.

@danner26 danner26 marked this pull request as draft December 26, 2024 18:21
@harryajc
Copy link
Collaborator

As these unofficial links is all that has changed with this PR I don't think it is required the comments section already has a link to the Juniper websites documentation for these devices

@harryajc harryajc closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: revisions needed This issue requires additional information to be actionable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants