Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Extreme X690 and X695 switches #2590

Merged
merged 7 commits into from
Dec 30, 2024
Merged

Add Extreme X690 and X695 switches #2590

merged 7 commits into from
Dec 30, 2024

Conversation

aaronaxvig
Copy link
Contributor

No description provided.

danner26
danner26 previously approved these changes Dec 30, 2024
View reviewed changes
@aaronaxvig
Copy link
Contributor Author

Sorry about the chain of commits. I couldn't figure out what the original issue was from the given errors, so took a shot in the dark. It was close but in a way was the opposite of what I needed to fix.

Seems to be good now though.

@danner26
Copy link
Member

Thanks @aaronaxvig I will re-review. In the future you can use pre-commit run -a to test, which will give you the actual errors. This is defined in the readme if you need to reference it

@danner26 danner26 merged commit 56f5b14 into netbox-community:master Dec 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danner26 danner26 danner26 approved these changes

Assignees
No one assigned
Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronaxvig @danner26