Skip to content

Commit

Permalink
chore: fix the CI benchmarks posting and also exit gracefully if not …
Browse files Browse the repository at this point in the history
…even relevant (#6966)

* chore: actually add deltas to the artifact as this changed from v3-v4

* chore: add conditions and check for file existence
  • Loading branch information
sarahetter authored Dec 18, 2024
1 parent d45e450 commit 5552659
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
9 changes: 8 additions & 1 deletion .github/workflows/benchmark-post.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,19 @@ jobs:
workflow: ${{ github.event.workflow.id }}
workflow_conclusion: success
name: delta-action-deltas
if_no_artifact_found: ignore
github_token: ${{ secrets.GITHUB_TOKEN }}
- name: Check File Existence
id: check-file-existence
uses: thebinaryfelix/[email protected]
with:
files: '.delta.*'
- name: Get PR number
if: github.event.workflow_run.event == 'pull_request'
if: github.event.workflow_run.event == 'pull_request' && steps.check-file-existence.outputs.exists == 'true'
id: pr_number
run: echo "pr_number=$(cat pr_number)" >> $GITHUB_OUTPUT
- name: Post deltas to GitHub
if: steps.check-file-existence.outputs.exists == 'true'
uses: netlify/delta-action@v4
with:
title: '📊 Benchmark results'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ jobs:
with:
name: delta-action-deltas
retention-days: 7
include-hidden-files: true
path: |
.delta.*
pr_number

1 comment on commit 5552659

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📊 Benchmark results

  • Dependency count: 1,227
  • Package size: 318 MB
  • Number of ts-expect-error directives: 876

Please sign in to comment.