Functions: Handle query parameters correctly (#976)

* Functions: Handle query parameters correctly * Add test for query parsing for functions requests * Formatting * paramsToObject: Preseve multiple values of same key * Simplify queryParams object creation * Express: Use 'simple' query parser
netlify · Jul 6, 2020 · 7ed8238 · 7ed8238
1 parent e9c3c6b
commit 7ed8238
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/utils/serve-functions.js b/src/utils/serve-functions.js
@@ -293,6 +293,7 @@ function createFormSubmissionHandler(siteInfo) {
 
 async function serveFunctions(dir, siteInfo = {}) {
   const app = express()
+  app.set('query parser', 'simple')
 
   app.use(
     bodyParser.text({

diff --git a/tests/dev.test.js b/tests/dev.test.js
@@ -153,6 +153,12 @@ test('functions: not found', async t => {
   t.is(response.status, 404)
 })
 
+test('functions: query parameters parsing', async t => {
+  const response = await fetch(`http://${host}/api/echo?category[SOMETHING][]=something`).then(r => r.json())
+
+  t.deepEqual(response.queryStringParameters, { 'category[SOMETHING][]': 'something' })
+})
+
 test('Netlify Forms support', async t => {
   const form = new FormData()
   form.append('some', 'thing')