Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra call to accounts endpoint across cli #6947

Merged
merged 9 commits into from
Dec 18, 2024

Conversation

sarahetter
Copy link
Contributor

@sarahetter sarahetter commented Dec 7, 2024

🎉 Thanks for submitting a pull request! 🎉

Summary

We're calling the non-minimal accounts API in @netlify/config and including it in the object returned from resolveConfig. Then we were doing it a second time in the CLI on a few different commands. The non minimal endpoint is really expensive so this saves a good chunk of time (a couple seconds in my testing).


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@sarahetter sarahetter requested a review from a team as a code owner December 7, 2024 00:52
@sarahetter sarahetter marked this pull request as draft December 7, 2024 00:53
@sarahetter sarahetter changed the title fix: remove extra call to accounts endpoint in status fix: remove extra call to accounts endpoint across cli Dec 18, 2024
@sarahetter sarahetter marked this pull request as ready for review December 18, 2024 00:42
Copy link

📊 Benchmark results

Comparing with a355ab7

  • Dependency count: 1,227 (no change)
  • Package size: 318 MB (no change)
  • Number of ts-expect-error directives: 875 ⬇️ 0.11% decrease vs. a355ab7

@sarahetter sarahetter enabled auto-merge (squash) December 18, 2024 00:46
@sarahetter sarahetter merged commit e6a4f59 into main Dec 18, 2024
49 checks passed
@sarahetter sarahetter deleted the sarahetter/speedy branch December 18, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants