Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove addons subcommand #6974

Merged
merged 2 commits into from
Dec 20, 2024
Merged

feat!: remove addons subcommand #6974

merged 2 commits into from
Dec 20, 2024

Conversation

sarahetter
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

This also has been deprecated for more than a year and gets less than one invocation a day.

Note: this keeps addons handling in dev, serve, functions. We should add observability/find observability that lets us know how much these are being used for any future versions of the CLI


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@sarahetter sarahetter requested review from a team as code owners December 20, 2024 20:02
Copy link

github-actions bot commented Dec 20, 2024

📊 Benchmark results

Comparing with afdfe46

  • Dependency count: 1,214 (no change)
  • Package size: 317 MB ⬇️ 0.00% decrease vs. afdfe46
  • Number of ts-expect-error directives: 830 ⬇️ 2.41% decrease vs. afdfe46

ndhoule
ndhoule previously approved these changes Dec 20, 2024
@sarahetter sarahetter enabled auto-merge (squash) December 20, 2024 20:07
@sarahetter sarahetter merged commit 9a88493 into main Dec 20, 2024
49 checks passed
@sarahetter sarahetter deleted the sarahetter/remove-addons branch December 20, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants