Move OC.Plugins, OC.msg and OC.Notification to the server bundle #13938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
requested review from
rullzer,
MorrisJobke,
skjnldsv and
juliusknorr
rullzer
approved these changes
Jan 31, 2019
ChristophWurst
added
4. to release
|
jsunit isn't happy |
Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
refactor/oc-plugins-msg-notifications
branch
from
9385637 to
52d388f
Compare
|
The problem was that webpack hides exported functions behind es5 getters and sinon does not support them yet: sinonjs/sinon#1762. I use webpack/webpack#6979 (comment) as solution. It's not ideal as webpack can't do all optimizations but the current bundle did not grow in size. |
ChristophWurst
added
3. to review
|
Yeah … I have to investigate.
is what I see a lot. But that variable is set via php and I assume we add a stub for tests somewhere. I don't get how this changed in this PR. |
|
I have to do this a bit differently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not reduce the number of requests but slims down the dreaded
js.jsand brings the code into a maintainable format.